Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directions Interface Compatibility Update #2350

Merged
merged 20 commits into from
Apr 17, 2020
Merged

Directions Interface Compatibility Update #2350

merged 20 commits into from
Apr 17, 2020

Conversation

JThramer
Copy link
Contributor

@JThramer JThramer commented Mar 12, 2020

Refactoring PR to enable support of mapbox/mapbox-directions-swift#418 and mapbox/mapbox-directions-swift#406. WIP.

To-Do:

  • Fix remaining compilation issues in MapboxCoreNavigation (6 issues)
  • Fix remaining compilation issues in MapboxNavigation (6 4 issues)
  • Fix remaining compilation issues in Example
  • Fix observable bugs in Example (tapping on alternate routes)
  • Fix remaining compilation issues in MapboxNavigationTests (30 issues)
  • Get Navigation tests to pass
  • Fix remaining compilation issues in MapboxCoreNavigationTests
  • Get Core Navigation tests to pass

/cc @mapbox/navigation-ios

@JThramer JThramer added op-ex Refactoring, Tech Debt or any other operational excellence work. epic labels Mar 12, 2020
@JThramer JThramer added this to the v1.0.0 milestone Mar 12, 2020
@JThramer JThramer self-assigned this Mar 12, 2020
@JThramer JThramer changed the title WIP: Directions Interface Compatibility Update Directions Interface Compatibility Update Apr 2, 2020
@JThramer
Copy link
Contributor Author

JThramer commented Apr 3, 2020

Blocked from merge by mapbox/mapbox-directions-swift#418, need to fix cartfile

@JThramer JThramer marked this pull request as ready for review April 3, 2020 03:12
Example/ViewController.swift Outdated Show resolved Hide resolved
@1ec5 1ec5 modified the milestones: v1.0.0, v0.x next Apr 14, 2020
@Udumft Udumft self-requested a review April 15, 2020 14:53
Copy link
Contributor

@Udumft Udumft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests a failing due to the dependencies which are not yet released and thus cannot be configured correctly in the .podspec.
Other than that, I don't see any issues.

@1ec5
Copy link
Contributor

1ec5 commented Apr 15, 2020

Some tests a failing due to the dependencies which are not yet released and thus cannot be configured correctly in the .podspec.

This is fine; we’ll have to put up with that failure until we push a new version of the MapboxDirections pod. We can make the CocoaPods checks not required or just use our administrator rights.

@Udumft Udumft merged commit a5937c7 into master Apr 17, 2020
@Udumft Udumft deleted the jerrad/new-direction branch April 17, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
op-ex Refactoring, Tech Debt or any other operational excellence work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants